Upgrade NPM packages, use Browserify directly

DavidWells / isomorphic-react-example

Deprecated! ReactJS + NodeJS ( express ) demo tutorial with video. Universal/Isomorphic JS = Shared JavaScript that runs on both the client & server.

http://davidwells.io

MIT License

1.69k stars 272 forks source link

Upgrade NPM packages, use Browserify directly #19

Closed gcpantazis closed 7 years ago

gcpantazis commented 8 years ago

Removes gulp-browserify.
Tested on Node v0.10, v4.0, v5.0

Hi there! I was having trouble checking this out due to some old dependencies (browserify depending on esprima-six, which no longer exists, specifically). So I upgraded them! gulp-browserify is abandoned, so I just used browserify.bundle() directly.

The output is rendering, but I can't compare it to the previous version so I'll defer to you on whether or not it's correct. :) Thanks for the example!

gcpantazis commented 8 years ago

Should probably resolve #18.

wstoettinger commented 8 years ago

it fixed npm install errors for me. thanks!

onefunman commented 8 years ago

Thx bro

benleung commented 8 years ago

thanks it fixed npm install error for me too

MaffooBristol commented 8 years ago

Hello, @DavidWells - any chance of merging this?

MaffooBristol commented 8 years ago

@gcpantazis - I actually have noticed another deprecation, all instances of require('react/addons') should be replaced with require('react')!

hansman commented 8 years ago

As on current master, 'browserify' is not required. https://github.com/DavidWells/isomorphic-react-example/blob/master/package.json#l16

gcpantazis commented 7 years ago

Hey all, I'm closing this since this project seems dead / I'd like to clean up my PR dashboard. If anyone else would like to own the PR / handle getting it merged with @DavidWells please feel free to cherrypick my patch! 👋