search

Davide-sd / sympy-plot-backends

An improved plotting module for SymPy
BSD 3-Clause "New" or "Revised" License
42 stars 9 forks source link

Fix to 3D plane when x and y are free symbols #13

Closed Chrillebon closed 1 year ago

Chrillebon commented 1 year ago

Bug found:

plot_geometry(Plane(p,n))

when the free parameters are x and y and the plane does not intersect x=0, y=0. The problem narrowed down to "PlaneSeries.get_data()".

Davide-sd commented 1 year ago

Hello @Chrillebon ,

can you please clarify with an example what's wrong?

Chrillebon commented 1 year ago

Hi Davide,

Great to hear from you! Really good work on spb, and thank you for being so quick to respond.

Yes, I did not quite have time to put together an example, why I saved it as a draft. I will put together an example, and finalize the PR soon.

Merry Christmas.

On Sat, Dec 24, 2022, 16:18 Davide Sandonà @.***> wrote:

Hello @Chrillebon https://github.com/Chrillebon ,

can you please clarify with an example what's wrong?

— Reply to this email directly, view it on GitHub https://github.com/Davide-sd/sympy-plot-backends/pull/13#issuecomment-1364544338, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHYVYSCYQSRFSVEPSDNUXGDWO4H5XANCNFSM6AAAAAATIOBB6I . You are receiving this because you were mentioned.Message ID: @.***>

Chrillebon commented 1 year ago

spb_plot_plane_error.zip

Files with examples showing how the current code "fails". The "mistake" lies in the plane not intersecting the point that it is made from. "Mistake" is only present when the free variables are both x and y.

The updated code fixes this.

Davide-sd commented 1 year ago

@Chrillebon Thank you very much for spotting this error and taking the time to implement a fix! I'll probably merge this PR tomorrow. In the meantime I'm going to think about how to implement tests for this. Thanks again, and merry merry Christmas! :)