search

Davide-sd / sympy-plot-backends

An improved plotting module for SymPy
BSD 3-Clause "New" or "Revised" License
42 stars 9 forks source link

set parameters of interactive plots to complex #20

Closed michelececcacci closed 1 year ago

michelececcacci commented 1 year ago

I can also add a unit test if you want, but first i'd like to get feedback

Davide-sd commented 1 year ago

Yes please, add a test with the expression found on issue #17 . I believe it should be sufficient to instantiate the series class, retrieve the data (for example s.get_data()) and verify that NaNs are not in the output.

michelececcacci commented 1 year ago

Ok, perfect!

michelececcacci commented 1 year ago

This should be fine. If anything can be made better let me know.

michelececcacci commented 1 year ago

I fixed everything you mentioned in your comments, but instantiating LineInteractiveSeries with n1=5 as a parameter does not affect the duration of test_complex eval. Not sure if i did something wrong.

Davide-sd commented 1 year ago

I fixed everything you mentioned in your comments, but instantiating LineInteractiveSeries with n1=5 as a parameter does not affect the duration of test_complex eval. Not sure if i did something wrong.

Don't worry about it: if you execute the example you will see that it evaluates over 5 points, instead of a 1000. This is going to make a tremendous difference when executing all tests at once.

Davide-sd commented 1 year ago

17

Davide-sd commented 1 year ago

Thanks for the PR :)