Closed krischer closed 5 years ago
I can provide some unit and integration test but i don't understand what you mean by the following sentence: especially compare the results against some known good result? Could you please be more specif about it?
The reference is to verification: establishing that the code computes the mathematical quantity it claims to. One could choose special inputs such that the outputs are known without running your code. Alternatively, you could compare to outputs produced by some trusted community code.
There are currently no tests or reproducible examples right now. I recommend setting up some unit and integration testing and especially compare the results against some known good result. Integration into a CI service would also be a good idea.
Part of a review at: https://github.com/openjournals/joss-reviews/issues/1049