search

DavideViolante / chartjs-plugin-labels

Plugin for Chart.js to display percentage, value or label in Pie or Doughnut.
MIT License
55 stars 18 forks source link

Allow for unlabeled charts along side labeled charts #12

Closed yousef337 closed 1 year ago

yousef337 commented 1 year ago

Hello, first of all, thanks for making this repository available since the original one is outdated. A minor issue with the labeling is that they are enforced in every chart, which make it difficult for a page to have both labeled and unlabeled charts. It would be a good idea to check for the options if the labels tag is available or not before going to the process. I've made the changes in a local repository, I am going to create a pull request if you think it should be added.

Thanks, Yousef Altaher

DavideViolante commented 1 year ago

Any PR is welcome

DavideViolante commented 1 year ago

Can you please show me before/after examples or screenshots? Thanks for the PR

yousef337 commented 1 year ago

Of course, here is some before/after images from a page that implemented the file After Before

After2 Before2