search

DavideViolante / chartjs-plugin-labels

Plugin for Chart.js to display percentage, value or label in Pie or Doughnut.
MIT License
58 stars 18 forks source link

Typescript version of the plugin for Angular usage #21

Closed eduard-landclan closed 1 year ago

eduard-landclan commented 1 year ago

Hi, I have migrated the plugin to typescript and I am using it with Angular. If you'd like us to collaborate on publishing for typescript, please let me know. Or you can add me as collaborator and I can open a pull request.

DavideViolante commented 1 year ago

I think you can open a PR also if you are not a collaborator, correct?

eduard-landclan commented 1 year ago

not sure really, I'm not able to push a new branch..

DavideViolante commented 1 year ago

You should fork this project, do the changes on your repo and then open the PR. https://docs.github.com/en/get-started/quickstart/contributing-to-projects

eduard-landclan commented 1 year ago

ok, sounds good. I will do that. However, there's one thing I would like to ask your help on. I will create the update needed for the Angular app to work, but I won't know if this is something we could use for React or Vue. The update will have a typescript file, it should work very similarly, but at the moment we have a pure javascript file. So it might be useful to check if we can use the typescript version of the react file too, or if this means we need to have two different implementations. I know most people are using react with typescript now, so it shouldn't be such a big problem. Would you be able to check that once I open a PR, please?

DavideViolante commented 1 year ago

I mostly use Angular. I think it won't be a big problem on react or vue. Anyway we will create a new tag version with the TS version and keep another tag for the current version, so people can use what works best for them.

eduard-landclan commented 1 year ago

Maybe this would do? https://github.com/DavideViolante/chartjs-plugin-labels/pull/22

If you want to have a look. We can probably improve together starting from this? please let me know what you think. You can comment directly in the PR. I cannot add you as a reviewer.

DavideViolante commented 1 year ago

I merged the PR, if there are issues, let's open another issue.