DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.22k stars 40 forks source link

Add support to non-steam games #176

Closed marco-calautti closed 1 year ago

marco-calautti commented 1 year ago

This fixes bug #175 . I tested it on my machine and everything seems to be working. I do not see yet why we would actually need to compute the shortcut ids using the CRC-based algorithm, since Steam does it for us already.

So, please verify I did not miss anything. I batch updated all my games with the new change, and everything worked fine.

DavidoTek commented 1 year ago

Thanks! :tada:

I do not see yet why we would actually need to compute the shortcut ids using the CRC-based algorithm, since Steam does it for us already.

Yes, we do not need to do that. It was only necessary in an older version of Steam.

So, please verify I did not miss anything. I batch updated all my games with the new change, and everything worked fine.

Did some tests, everything seems to work fine.

We may want to split up the #get non-steam apps-part into a separate function (e.g. get_steam_shortcuts_list) to keep the code clean and keep it outside the try-catch of the #get steam apps-part. We can call it inside get_steam_app_list though. Maybe add another try-catch with apps = get_steam_shortcust_list(apps).

marco-calautti commented 1 year ago

We may want to split up the #get non-steam apps-part into a separate function (e.g. get_steam_shortcuts_list) to keep the code clean and keep it outside the try-catch of the #get steam apps-part. We can call it inside get_steam_app_list though. Maybe add another try-catch with apps = get_steam_shortcust_list(apps).

I refactored the code in a separate function.

DavidoTek commented 1 year ago

Thanks! Will merge it.