search

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.22k stars 40 forks source link

Fix Steam AppID sort in ctinfodialog #179

Closed sonic2kk closed 1 year ago

sonic2kk commented 1 year ago

In the ctinfodialog, sorting by Steam AppID doesn't work properly. I guess it tries to sort them as strings instead of numbers. The fix for this is a small change to set the data properly as an integer. In my tests, a call to setData is actually required, as just QTableWidgetItem(int(game.get_app_id_str())) results in an empty AppID column :shrug:

image

My bad for missing this initially. No change should be needed on the Lutris side as Lutris is sorted by slugs, which are strings anyway. I think Steam even stores AppIDs as integers so there shouldn't be any problem with setting the data type as integer.

Thanks :smile:

DavidoTek commented 1 year ago

Thanks very much for also fixing those little issues! :tada:

Never tried sorting by AppID (I only have a few games installed...), but great it is fixed now :smile: