sonic2kk
commented
1 year ago tl;dr - After investigation this seems to happen when the ~/.local/share/Steam/appcache/appinfo.vdf file is blank or when it does not exist, but only on 2.7.7. I can reproduce with Flatpak 2.7.7 and from source when checking out the 2.7.7 release commit (dbb21d3dfe6a57ddbd9370d70ff9c731023b3bee) if I rename/move my appinfo.vdf file with Steam closed, and then open ProtonUp-Qt. I cannot reproduce on master, the games list dialog is just empty (and all compat tools show up as unused ofc).
It seems to have been fixed following #171 (d3dfd1f5746c5f49408f06015162e52094f1ac93) as the error does not happen for me when checking out that commit, but does occur when checking out the commit prior (60c0048987b81b3d6cf23f671c2e5ac5673eb306).
So this should be fixed in the next release it seems.
2.7.6 doesn't seem like its the latest version, I believe 2.7.7 is the latest. There was a fix for the steam library in 2.7.7 (added in https://github.com/DavidoTek/ProtonUp-Qt/commit/b3afaac4a4108ff46c11fe48a628e2e4a64cf048) I believe, which could explain the issue you're seeing here.
If you were using the Flatpak I'm not sure how it was out of date though. Not seeing the error myself.
The initial error seems to be coming from the steamutil.get_steam_app_list helper method. It has a try/except block when it tries to parse libraryfolders.vdf and config.vdf (internal Steam files). It is possible that somehow these files do not exist, which would mean that it's falling over when ProtonUp-Qt tries to get data from them.
I tried removing these two files and ProtonUp-Qt fell over right away because they didn't exist (shouldn't happen with a proper Steam install). I tried emptying these files each, and then emptying both of them, and ProtonUp-Qt just showed a blank dialog. In the case of both files existing but being blank, I also got the Error: Could not get a list of all Steam apps: 'NoneType' object is not iterable error. Maybe we can put aside the first error then as it seems relatively harmless(?).
Next I'll turn my attention to the steamutil#_get_steam_ctool_info function. This tries to get a map for all compat tools used by Steam. By default this compat_tools is None, but it tries to get the compat tools using a for loop:
try:
with open(appinfo_file, 'rb') as f:
header, apps = parse_appinfo(f)
for steam_app in apps:
if steam_app.get('appid') == 891390:
compat_tools = steam_app.get('data').get('appinfo').get('extended').get('compat_tools')
break
except:
pass
finally:
for t in compat_tools:
ctool_map[compat_tools.get(t).get('appid')] = {'name': t, 'from_oslist': compat_tools.get(t).get('from_oslist')}So perhaps compat_tools is never being set to anything other than None. I don't think this should ever happen. It would mean the steam_app.get('appid') == 891390 condition is never true.
Just out of curiosity, have you launched Steam and installed any games that use any compatibility tools? Maybe that's the issue here?
Looking at SteamDB, that AppID appears to represent some various game configs that automatically apply workarounds to various games in order to improve support? For example I can see this as an entry in the parsed steam_app coming back from the VDF parser: '3590': {'appid': 3590, 'config': 'cmdlineappend:-changedir', 'comment': 'Plants vs. Zombies GOTY Edition' - This -changedir is a known workaround needed for various PopCap games, I remember having to set this to play various g ames including Plants vs. Zombies.
I don't know why this data wouldn't exist. Can you check if you have an AppInfo file at ~/.local/share/Steam/appcache/appinfo.vdf and that it is a reasonable size (i.e. not empty, a few MBs probably).
With an empty appinfo.vdf file I can reproduce the error on Flatpak and going back to the 2.7.7 release commit from source (dbb21d3dfe6a57ddbd9370d70ff9c731023b3bee) but not from the latest master (643d611b23e284449f4fddf3de12a6aab25f3065).
Traceback (most recent call last):
File "/app/lib/python3.10/site-packages/pupgui2/pupgui2.py", line 304, in btn_show_game_list_clicked
gl_dialog = PupguiGameListDialog(install_directory(), self.ui)
File "/app/lib/python3.10/site-packages/pupgui2/pupgui2gamelistdialog.py", line 34, in __init__
self.setup_ui()
File "/app/lib/python3.10/site-packages/pupgui2/pupgui2gamelistdialog.py", line 48, in setup_ui
self.update_game_list_steam()
File "/app/lib/python3.10/site-packages/pupgui2/pupgui2gamelistdialog.py", line 70, in update_game_list_steam
ctools.extend(t.ctool_name for t in get_steam_ctool_list(steam_config_folder=self.install_loc.get('vdf_dir')))
File "/app/lib/python3.10/site-packages/pupgui2/steamutil.py", line 85, in get_steam_ctool_list
ctool_map = _get_steam_ctool_info(steam_config_folder)
File "/app/lib/python3.10/site-packages/pupgui2/steamutil.py", line 140, in _get_steam_ctool_info
for t in compat_tools:
TypeError: 'NoneType' object is not iterable
theskyover
DavidoTek
Please fill out following when reporting a new bug:
Describe the bug
Clicking the "Show game list" button in the main menu does nothing, and produces an error in the command line.
Desktop (please complete the following information):
Additional context
I am working with a fresh install of Nobara. Steam is not flatpak-based, nor is ProtonUp-Qt.
Terminal output
This is the terminal output upon clicking the button: