search

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.22k stars 40 forks source link

Heroic: Type Hint cleanup #213

Closed sonic2kk closed 1 year ago

sonic2kk commented 1 year ago

I made a pretty bad mistake when implementing the Heroic util stuff. For some reason I tried to type hint assigning the values to the HeroicGame object. I recently re-configured my vscodium install to get my development environment in order and this was something it yelled at me about this :sweat_smile:

This also removes what appears to be an unused element, hg.install, which was not part of the HeroicGame data structure - I think this was discussed and removed from the data structure, but it seems I missed heroicutil.

As far as I know this shouldn't have caused any problems, but it's invalid usage of type hints, so my bad there.

DavidoTek commented 1 year ago

Yeah, I noticed that all the types were hinted. My first thought was that it is for better readability though vscode/ium/... should show the types when hovering over them.

As far as I know this shouldn't have caused any problems, but it's invalid usage of type hints, so my bad there.

I don't think that's how they are supposed to be used but Python doesn't hinder anyone from using them like that :)

Thanks.