search

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.17k stars 39 forks source link

Proton-tkg: Remove unnecessary variables from subclasses #264

Closed sonic2kk closed 12 months ago

sonic2kk commented 1 year ago

Removes some duplicated variables from the Proton-tkg subclasses, like the buffer size and signal. These are already set by the main Proton-tkg class and the values didn't change for the subclasses, so we don't need to set them.

Did a quick spot check and this didn't break anything, Tkgs still downloaded successfully for Lutris, Heroic and Steam.

This is just minor code maintenance, and has no impact on functionality. So no screenshots for this one :-)

sonic2kk commented 1 year ago

Hm, just had a quick glance on my phone, I think there are some unused imports now (mainly for Signal). I can clean those up.

sonic2kk commented 1 year ago

Removed unused imports. I left the comments as-is, not sure if we want to update the names to distinguish Proton-tkg/Wine-tkg, or even things like the copyright years.

DavidoTek commented 12 months ago

Thanks, I appreciate. That keeps the code clean :)

Sorry for the delayed response, there's quite a lot of other stuff to do lately..

sonic2kk commented 12 months ago

No worries, real life comes first!