search

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.25k stars 40 forks source link

Fixed non steam game names not shown #275

Closed GreatApo closed 1 year ago

GreatApo commented 1 year ago

For some reason, my steam deck has AppName as lowercase in the .steam/steam/userdata/xxxxx/config/shortcuts.vdf This is a quick fix that supports both uppercase and lowercase variations.

sonic2kk commented 1 year ago

Looks great and good catch!

Tested locally and this doesn't cause any regressions with my shortcuts.vdf file on my PC which has a CamelCase key name, though it is not a very extensive list of shortcuts. Since the shortcuts.vdf file uses the binary VDF format, I wasn't able to test editing it to use a lowercase key name, but I assume it will work from looking at the code.

This reminds me of an issue for #226 where one of the VDF files keys had a casing issue - valve instead of Valve (fixed in #227). It seems VDF file casing can be rather inconsistent. On my Steam Deck, shortcuts display fine fwiw, so I'd go out on a limb and say these are Steam bugs. Regardless it's good to fix them in ProtonUp-Qt as well.

DavidoTek commented 1 year ago

Thanks!

Tested locally and this doesn't cause any regressions with my shortcuts.vdf file on my PC which has a CamelCase key name, though it is not a very extensive list of shortcuts

Seems good, I don't think it can break anything.

It seems VDF file casing can be rather inconsistent.

Definitively.