Add a Steam Shortcut Editor

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.

https://davidotek.github.io/protonup-qt

GNU General Public License v3.0

1.17k stars 39 forks source link

Add a Steam Shortcut Editor #282

Closed DavidoTek closed 9 months ago

DavidoTek commented 10 months ago

This PR adds a Shortcut Editor for Steam (both Native and Flatpak supported).

Currently, editing the App Name, Executable Path, Starting Directory and App Icon is supported.

grafik

TODO/DONE:

[x] Add a Delete Button
- Mark shortcut (red text) and delete it after pressing Save
[x] Allow adding new shortcuts
- Determine a user for new shortcuts like this: Check if there are already other shortcuts
  - If there are: Use the most common user across the other shortcuts
  - Otherwise: Determine which Steam user was most recently logged in
  - If there isn't any Steam user (e.g. fresh install): Return and don't do anything - currently no user feedback
[x] Maybe resize the window a bit

Later TODOs (for later PRs):

Add a tool button that lets the user choose an executable/directory using a file dialog
Modify the available columns / let the user choose
Fix the Start In field automatically: https://github.com/DavidoTek/ProtonUp-Qt/pull/282#discussion_r1331177772

sigboe commented 9 months ago

Launch options is a generally a nice thing to be able to edit

sonic2kk commented 9 months ago

This is really awesome. There are some other fields which may only be useful in some cases (such as the Steam Overlay conditional). There's a "hidden" flag but in my own testing I couldn't get it to work, so I'm not sure if it's worth adding.

Another thing I'm thinking is how difficult it would be to add some kind of way to browse for executables/icons. I couldn't think of an easy way to do this myself so I don't have any suggestions 😅

I love this though. As someone who has also worked a lot recently with the damn shortcuts.vdf I can say any software that makes it less of a pain to work with, the better!

sigboe commented 9 months ago

Another thing I'm thinking is how difficult it would be to add some kind of way to browse for executables/icons. I couldn't think of an easy way to do this myself so I don't have any suggestions 😅

@sonic2kk I don't know really about the Qt framework widgets that well, but the (I don't know the actual name) list/table view widget in OP's picture. Is it possible to add a browse button in the relevant fields that is only visible when the relevant field is selected? And then just open the Qt file/folder chooser

DavidoTek commented 9 months ago

There are some other fields which may only be useful in some cases (such as the Steam Overlay conditional). There's a "hidden" flag but in my own testing I couldn't get it to work, so I'm not sure if it's worth adding.

Adding new column is mostly straight forward. We can discuss which are important, I just chose ones that seemed relevant to me.

browse for executables/icons [..] Is it possible to add a browse button in the relevant fields that is only visible when the relevant field is selected? And then just open the Qt file/folder chooser

It is possible to add Qt Widgets to the QTableWidget. By adding QLineEdit and a QToolButton inside of a QHBoxLayout this should work. The logic for updating text in txt_changed would need to be revised though.