search

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.17k stars 39 forks source link

SteamTinkerLaunch: rename 'xwinfo' to 'xwininfo' #301

Closed sonic2kk closed 8 months ago

sonic2kk commented 8 months ago

FIxes #300.

There is an AUR package called xwinfo (repo), which seems similar (equivalent?) to xwininfo. When installing SteamTinkerLaunch, if ProtonUp-Qt can't find which xwininfo, instead of using this name, displays the xwininfo dependency name as xwinfo. Even if xwinfo is installed it will not return anything for which xwininfo, as its command name is xwinfo. SteamTinkerLaunch also expects to find a command xwininfo, it is not compatible with xwinfo. It could be possible for SteamTinkerLaunch to use xwinfo if it is truly equivalent to xwininfo, but I'd honestly rather stick to official packages only for a dependency like this.

This PR fixes the SteamTinkerLaunch dependencies screen to now show xwininfo as the dependency name instead of xwinfo. We even run host_which('xwininfo'). Not sure why we used xwinfo back then, but I don't think there's any strong reason to keep it :-)

So while the package name alone is not a huge issue, it's the fact that xwinfo uses the command name xwinfo instead of xwininfo. Phew! Hope that makes sense.

Thanks!

DavidoTek commented 8 months ago

Thanks. Should make it also more clear for other distros that don't use that AUR package name, googeling that command should yield a name of the packet for your distribution.