search

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.17k stars 39 forks source link

Roberta: Use fetch_project_releases and fetch_project_release_data #310

Closed sonic2kk closed 7 months ago

sonic2kk commented 7 months ago

Updates the Roberta ctmod to use util#fetch_project_releases and util#fetch_project_release_data from #302.

I chose Roberta as a straightforward and lower-cost way to proof this method out for other ctmods :-)

sonic2kk commented 7 months ago

I have noticed that some of them (Luxtorpeda, Roberta, Boxtron) seem pretty similar minus their dependencies. I was planning to go ahead and make these changes in separate PRs for these three tools, however because they're so similar, I may try to refactor these to use a common ctmod first. They're sister projects of one another I believe anyway so I think this makes sense.

Instead of making three separate PRs to make the fetching changes, and then exploring a refactor to make these ctmods common, I think I'll just make them common. Then, if that fails (i.e if it becomes difficult to set overrides to how we fetch assets for some reason) I can go back to this approach.