This PR changes the description of the Valve Wine and Vanilla Wine -tkg builds to note which branch they use for clarity.
Valve Wine uses Valve's bleeding_edge branch, which is what their experimental_X.X branches are based on (ValveSoftware/wine branches: https://github.com/ValveSoftware/wine/branches). It also changes the name of the Vanilla Wine ctmod file for consistency with this change.
The wine-tkg-git workflow calls this wine-valvexbe where "xbe" is eXperimental Bleeding Edge.
Vanilla Wine uses Wine Master built on an Ubuntu CI
I think we had some discussion about which CI to use and how to name these at the time, but I think using these names is a bit clearer. Noting the CI used for Wine Master might seem a little strange though, but I think it's an important distinction as the Ubuntu CI has different dependencies and thus builds Wine differently. The main distinction as far as I know currently being the Ubuntu CI is not built with Wine 9.0's Wayland support enabled. However, the Arch CIs are built with Wayland support.
If search for wayland in the two logs, you will see the Ubuntu CI only has 31 results, whereas the Arch CI has 72 results.
I learned this the hard way the other night when I couldn't figure out why I couldn't get any Wine 9.0 builds to properly enable the Wayland driver (Arch's Wine package is not built with --with-wayland for fear of introducing the Wayland dependencies unnecessarily for an experimental in-development feature that is off by default).
Even if/when the Ubuntu CI is updated, it might be good to note it in the description of this tool. I think we skipped putting this in the name before for concerns of confusing users thinking that the Ubuntu CI might only be for Ubuntu, but I think putting it in brackets should be fine.
The ctmod names were also updated to better reflect their branches. In hindsight, "Valve Wine" doesn't carry the implication that it's the latest bleeding_edge, and it's not clear that this is the latest Valve Wine patch. It's equivalent to selecting Proton Experimental in your library -> Properties -> Betas, and selecting the "bleeding_edge" beta (although this means every game using Proton Experimental will use the bleeding_edge branch, which is normally undesirable). We could update the description further to note this in some way.
This PR was motivated by my own misunderstandings, and I thought that it might be good to further clarify what the Wine-tkg builds are using.
With this PR, I essentially want to find a way to make it clearer to users what the Wine-tkg builds are using, because this can be important in some cases. I don't know if I've done it in the best way in this PR, so all feedback on phrasing welcome :slightly_smiling_face:
DavidoTek
commented
7 months ago
This PR changes the description of the Valve Wine and Vanilla Wine -tkg builds to note which branch they use for clarity.
bleeding_edgebranch, which is what theirexperimental_X.Xbranches are based on (ValveSoftware/wine branches: https://github.com/ValveSoftware/wine/branches). It also changes the name of the Vanilla Wine ctmod file for consistency with this change.wine-valvexbewhere "xbe" is eXperimental Bleeding Edge.customisation.cfg: https://github.com/Frogging-Family/wine-tkg-git/blob/edf80e3ecdcf69555f2359433003dd635b3b5798/wine-tkg-git/customization.cfg#L55I think we had some discussion about which CI to use and how to name these at the time, but I think using these names is a bit clearer. Noting the CI used for Wine Master might seem a little strange though, but I think it's an important distinction as the Ubuntu CI has different dependencies and thus builds Wine differently. The main distinction as far as I know currently being the Ubuntu CI is not built with Wine 9.0's Wayland support enabled. However, the Arch CIs are built with Wayland support.
waylandin the two logs, you will see the Ubuntu CI only has 31 results, whereas the Arch CI has 72 results.I learned this the hard way the other night when I couldn't figure out why I couldn't get any Wine 9.0 builds to properly enable the Wayland driver (Arch's Wine package is not built with
--with-waylandfor fear of introducing the Wayland dependencies unnecessarily for an experimental in-development feature that is off by default).Even if/when the Ubuntu CI is updated, it might be good to note it in the description of this tool. I think we skipped putting this in the name before for concerns of confusing users thinking that the Ubuntu CI might only be for Ubuntu, but I think putting it in brackets should be fine.
The ctmod names were also updated to better reflect their branches. In hindsight, "Valve Wine" doesn't carry the implication that it's the latest
bleeding_edge, and it's not clear that this is the latest Valve Wine patch. It's equivalent to selecting Proton Experimental in your library -> Properties -> Betas, and selecting the "bleeding_edge" beta (although this means every game using Proton Experimental will use the bleeding_edge branch, which is normally undesirable). We could update the description further to note this in some way.This PR was motivated by my own misunderstandings, and I thought that it might be good to further clarify what the Wine-tkg builds are using.
With this PR, I essentially want to find a way to make it clearer to users what the Wine-tkg builds are using, because this can be important in some cases. I don't know if I've done it in the best way in this PR, so all feedback on phrasing welcome :slightly_smiling_face:
Thanks!