search

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.16k stars 39 forks source link

constants: Bump copyright year #385

Closed sonic2kk closed 2 months ago

sonic2kk commented 2 months ago

Was tinkering around with the new Flatpak KDE 6.7 update to see if any of the small oddities were fixed (like the wrong cursor being used, and some things displaying incorrectly on Wayland, and they were fixed!) and happened to notice the copyright year wasn't bumped.

As far as I could see, this text isn't translated, and has only been changed a handful of times (most recently in #222). Making this text translatable might be as straightforward as changing its usage in pupgui2aboutdialog.py to be self.ui.lblAboutVersion.setText(self.tr(ABOUT_TEXT)), but my understanding of translations is still not great. Since this text is using .format in constants.py and would not be calling it directly on self.tr I'm not sure if all that would play nicely together.

DavidoTek commented 2 months ago

Thanks.

the wrong cursor being used, and some things displaying incorrectly on Wayland, and they were fixed!)

That's very good.

Making this text translatable might be as straightforward as changing its usage in pupgui2aboutdialog.py to be self.ui.lblAboutVersion.setText(self.tr(ABOUT_TEXT)), but my understanding of translations is still not great

I don't think we need to translate it.

Since this text is using .format in constants.py and would not be calling it directly on self.tr I'm not sure if all that would play nicely together.

Yes, that would need to be changed. self.tr is looking for the given string in the translations files. If the parameters in the text are inserted before calling self.tr, it won't find the correct string. It works when the parameters are included in the translation origin string as well as the translated string.