DavidoTek
commented
2 months ago Thanks!
I haven't been able to test if this change works for the native Portal dialogs, but given that all this should be managed by Qt, I would say either they should already work and if they don't it's likely an upstream bug out of our hands.
Didn't work with GNOME, actually. (PySide 6.7, GNOME 46, native Python) The implementation seems correct however, so could be a problem with the portal/GNOME.
And with the Qt dialog, unlike the KDE (and I believe GNOME?) portals, there is no shortcut to show hidden files
GNOME has the shortcut.
The portal will also not show hidden files by default even if your file manager has this enabled. Likely because there's no sort of "global preference" for this and you can have multiple file managers, it's still worth noting that by default this behaviour is always off. Maybe I'm an edge case, but I would prefer to have these always on and especially so in the use-case of looking for launcher directories that are often in hidden folders.
Hmm, you're right, the portal file picker doesn't respect the file managers decision. Apparently, the file pickers are separate from the file manager, at least on GNOME: https://github.com/microsoft/vscode/issues/107246#issuecomment-1463879326 In the issue, the file picker overrides the global settings of the file manager though, strange.
If not wanted it's not a huge deal to keep hidden folders disabled by default, but I think it's a useful addition for the context that the dialog is used in, which can very often be to look for folders in hidden directories.
I think it can be a useful addition. If there again is an issue like https://github.com/DavidoTek/ProtonUp-Qt/pull/381, this could help.
EDIT: Tested it from inside the Flatpak, will not show the hidden files on GNOME either. I will merge this nevertheless as the implementation seems correct.
sonic2kk
Overview
This PR enables hidden folders by default for the Custom Install Directory dialog. This makes the dialog easier to browse when clicking through folders to find, for example, an alternative Steam installation location. Launcher installations are often in hidden directories, so I think it makes sense to enable hidden files by default.
mainThis PR
This change also has the benefit of allowing suggestions when typing the path to a hidden folder. On
main, if you type~/.local/share/Steam, you won't get any autocomplete, which might suggest a folder doesn't exist when it in fact does, the dialog is just hiding the hidden folder.Since launchers often deal with hidden folders, I think it makes sense to have this on by default. For example if a user was using a custom version of a launcher that had a different path but still in
~/.local/share, with this change you can see the suggestion appears.Note: Since the KDE Runtime 6.7 bump, the Flatpak is actually using the KDE Portal for the file dialog, but the AppImage and running from source, and possibly also AUR packages, are not. Also, if a user didn't have the relevant Portals on their system, Qt would probably fall back to the Qt file picker. I haven't been able to test if this change works for the native Portal dialogs, but given that all this should be managed by Qt, I would say either they should already work and if they don't it's likely an upstream bug out of our hands.
mainThis PR
Justification
You can right-click and select "Show hidden files", but ProtonUp-Qt doesn't use context menus anywhere else, and this context menu comes from Qt behaviour. I think a sensible default it showing the hidden folders by default. Also, even when the dialog is set to only show directories, the context menu item still says "Show hidden files" which may not be immediately obvious either.
And with the Qt dialog, unlike the KDE (and I believe GNOME?) portals, there is no shortcut to show hidden files. The portal will also not show hidden files by default even if your file manager has this enabled. Likely because there's no sort of "global preference" for this and you can have multiple file managers, it's still worth noting that by default this behaviour is always off. Maybe I'm an edge case, but I would prefer to have these always on and especially so in the use-case of looking for launcher directories that are often in hidden folders.
Also, when you select "Show hidden files" from the right-click context menu, this isn't remembered the next time you open the dialog. So if you enable this option and then close the dialog, this setting is forgotten and you have to enable hidden files again. Although with this change a user who doesn't want hidden files would have to disable it each time.
Implementation
This feature is something I personally have wanted for a long time but couldn't figure out how to do it with Qt, so I spent the last couple of days investigating and happened across a tucked-away section of the Qt docs on how to implement it: https://doc.qt.io/qtforpython-6.2/PySide6/QtCore/QDir.html (Ctrl+F for "List hidden files" to get the member reference).
We can use
QFileDialog.setFilter()with a few options to achieve the result we want here. We can't just useQDir.Hiddenbecause the filter doesn't know if we want to filter by directories, files, or both, so just usingQDir.Hiddenwould result in an empty list. We can addQDir.Dirsto tell the dialog to show folders. Order probably doesn't matter but I put it at the start because I think it makes the filter read more naturally. Finally, these two options alone result in the.and..folders being shown on the dialog. Personally I felt it was best to hide those so I hid them withQDir.NoDotAndDotDotwhich is a fantastic name (we don't show them currently anyway and most file pickers don't, although it can be handy in some file browsers).If not wanted it's not a huge deal to keep hidden folders disabled by default, but I think it's a useful addition for the context that the dialog is used in, which can very often be to look for folders in hidden directories.
Thanks!