search

DavidoTek / ProtonUp-Qt

Install and manage GE-Proton, Luxtorpeda & more for Steam and Wine-GE & more for Lutris with this graphical user interface.
https://davidotek.github.io/protonup-qt
GNU General Public License v3.0
1.26k stars 40 forks source link

App doesn't show installed official version from Steam #469

Closed Tiagoquix closed 3 days ago

Tiagoquix commented 4 days ago

Describe the bug
I have GE-Proton and Proton 3.16 (for a specific old game). It doesn't show in the compatibility tools list. Oddly enough, the anti-cheat is there.

To Reproduce
Steps to reproduce the behavior: Open the app and see that it doesn't show Proton 3.16 from Steam.

The app shows the version as available in the "Show game list".

Expected behavior
Should show installed versions from Steam.

Screenshots
image

image

Desktop (please complete the following information):

Additional context
No additional context.

Terminal output 

ProtonUp-Qt 2.10.0 by DavidoTek. Build Info: DavidoTek Flathub build.
Python 3.11.10 (main, Nov 10 2011, 15:00:00) [GCC 13.2.0], PySide 6.7.0
Platform: KDE Flatpak runtime 6.7 Linux-6.11.3-200.fc40.x86_64-x86_64-with-glibc2.38
Qt: Session management error: Could not open network socket
Loading locale en / en_US
Loaded ctmod GE-Proton
Loaded ctmod Wine-GE
Loaded ctmod Boxtron
Loaded ctmod Kron4ek Wine-Builds Vanilla
Loaded ctmod Lutris-Wine
Loaded ctmod Luxtorpeda
Loaded ctmod Northstar Proton (Titanfall 2)
Loaded ctmod Proton Tkg
Loaded ctmod Proton Tkg (Wine Master)
Loaded ctmod Roberta
Loaded ctmod Steam-Play-None
cat: /etc/lsb-release: No such file or directory
Loaded ctmod SteamTinkerLaunch
cat: /etc/lsb-release: No such file or directory
Loaded ctmod SteamTinkerLaunch-git
Loaded ctmod vkd3d-lutris
Loaded ctmod vkd3d-proton
Loaded ctmod Wine Tkg (Valve Wine Bleeding Edge)
Loaded ctmod Wine Tkg (Wine Master)
Loaded ctmod DXVK
Loaded ctmod DXVK Async
Loaded ctmod DXVK (nightly)
Gamepad error: No gamepad found.
$ lsb_release -a
LSB Version:    n/a
Distributor ID: Fedora
Description:    Fedora Linux 40 (KDE Plasma)
Release:        40
Codename:       n/a
sonic2kk commented 3 days ago

This isn't a bug from my understanding of the code, ProtonUp-Qt intentionally skips Steam Proton versions, I assume because they're expected to be managed from the Steam Client.

Tiagoquix commented 3 days ago

Your comment makes sense. Thanks for the clarification.

On an unrelated note, it's weird to show the anti-cheat (that is also installed through the Steam Client), because it's not possible to manage it.

sonic2kk commented 3 days ago

That's a fair point. Maybe we want to display Proton versions in a similar way. That would be up to the maintainer, but my understanding of the code is that they are skipped for whatever reason. Proton Anti-Cheat runtimes are intentionally checked:

https://github.com/DavidoTek/ProtonUp-Qt/blob/d7c71a8e0b6f37a9a1832cd89a8d9c8fdccc6cf0/pupgui2/steamutil.py#L306-L307

I am not voicing agreement one way or the other as-such, just stating my understanding of why regular Proton versions are not parsed, but not trying to say it's the reason or that it should or should not change :-)