search

Davidobot / BetterJoy

Allows the Nintendo Switch Pro Controller, Joycons and SNES controller to be used with CEMU, Citra, Dolphin, Yuzu and as generic XInput
Other
3.91k stars 344 forks source link

[BUG] Problems with culturesettings #882

Closed BurndiL closed 2 years ago

BurndiL commented 2 years ago

Description There is a parsing issue: because in the App config file the float values are stored with a "." as separator, the float.parse() gives an exception on my machine, because I live in some european country and my culture setting separator thingy is ",". I've built my own betterjoy instance and fixed it already, but I can imagine this being an issue in the future for other people. I set the culture to "en-US" in the main method, but this is probably just a bodge, so feel free to fix it some other way. And this only happens on v7.0, which is kinda strange

Davidobot commented 2 years ago

Ah, thanks for the clarification on the specific issue. Bizarre to say the least. Could you push your fix as a pull request? I'll get it merged asap

BurndiL commented 2 years ago

I hope i did the pull request thingy right

Davidobot commented 2 years ago

I hope i did the pull request thingy right

You did! Thanks!