Davidobot / BetterJoy

Allows the Nintendo Switch Pro Controller, Joycons and SNES controller to be used with CEMU, Citra, Dolphin, Yuzu and as generic XInput
Other
3.85k stars 341 forks source link

[BUG] Application crashes with "Enable Rumble" disabled #944

Open plxjammerplx opened 2 years ago

plxjammerplx commented 2 years ago

Application crashes upon connecting with official Switch Pro controller with "Enable Rumble" disabled on Windows 11. Upon restarting the application with "Enable Rumble" re-enabled prior to connecting the official Switch Pro controller, the application functions normally.

I have only tested this with version 7 and 7.1, both versions of the applications regardless of ViGEm or HIDGuardian drivers the results are the same on Windows 11.

gauraoo33 commented 2 years ago

I also have experienced this issue with windows 11. I am using version 7.1. Upon disabling the "enable rumble" setting. The application crashes. Attempting to reopen it after this does not work and I was forced to delete and reinstall the program.

plxjammerplx commented 2 years ago

I also have experienced this issue with windows 11. I am using version 7.1. Upon disabling the "enable rumble" setting. The application crashes. Attempting to reopen it after this does not work and I was forced to delete and reinstall the program.

You don't have to reinstall, simply just re-enable that option before connecting any controller to your pc. The application won't crash without any controllers connected.

GormAuslander commented 2 years ago

I am having this issue on windows 10. Immediately after hitting "Apply" after unchecking that box, it crashes. Attempting to launch it while EnableRumble=false results in an immediate crash. I have to edit the config, setting EnableRumble=true in order to use it again.

plxjammerplx commented 2 years ago

I have reinstalled Windows 10 and this problem happens on Windows 10 as well, I can no longer disable controller rumble without having application crash on me when controller is connected. This is with the official Nintendo Switch Pro controller.

Horonelius commented 2 years ago

Getting this same issue with Windows 10 21H2. If rumble is disabled, the icon appears in the system tray, and vanishes as soon as I mouse over it.

SmokePuddingEveryday commented 1 year ago

Still an issue on Windows 10.

Gio697 commented 1 year ago

Has anyone found a fix to this problem?

finalgene commented 8 months ago

I made a pull request to fix this problem and you may download the hotfix release from my fork https://github.com/qiaowencong/BetterJoy/releases/tag/v7.1 tested with win10 21h2