The build procedure is inconsistent in windows and linux scripts

Davidobot / love.js

LÖVE ported to the web using Emscripten, updated to the latest Emscripten and LÖVE (v11.5)

MIT License

624 stars 28 forks source link

The build procedure is inconsistent in windows and linux scripts #98

Closed ParticleG closed 1 week ago

ParticleG commented 1 week ago

I've forked the repo and made a github action workflow for it: main.yml

And I noticed the cmake parameters are different in build_lovejs.bat and build_lovejs.sh , I use linux script for reference and successfully built a compat version release

I also noticed the release version failed to built due to --shared-memory issue

Could you please take a look and help me fix the build procedure?

ParticleG commented 1 week ago

Also the compat version can't launch the game due to:

Uncaught TypeError: Module.getMemory is not a function
    at processPackageData (game.js:230:38)
    at putMetadataRequest.onsuccess (game.js:209:11)

ParticleG commented 1 week ago

Figured it out. It's due to using a newer version of emsdk