search

Davidrxyang / raines-2024-line-addition-problem

MIT License
1 stars 0 forks source link

reworked bits of evaluation #71

Closed Davidrxyang closed 1 week ago

Davidrxyang commented 1 week ago
  1. clarified what is "good" and "bad" and reworked network efficiency calculation

total network efficiency = (sum: complexity of each route ridership of each route) total cost

  1. implemented adjusted complexity
Davidrxyang commented 1 week ago

this one actually needs a lookover, sanity check my logic

Davidrxyang commented 1 week ago

70

henrydeng2002 commented 1 week ago

In adjustedRouteComplexity, you end up returning factor simpleComplexity which ends up being simpleComplexity^2 / (adjustmentWeight geographicalDistance). Not sure if the squaring is intentional Otherwise I think logic looks good

Davidrxyang commented 1 week ago

Yea squaring is intentional

Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Henry Deng @.> Sent: Sunday, July 7, 2024 1:43:23 PM To: Davidrxyang/raines-2024-line-addition-problem @.> Cc: Ruoxing (David) Yang @.>; Author @.> Subject: Re: [Davidrxyang/raines-2024-line-addition-problem] reworked bits of evaluation (PR #71)

In adjustedRouteComplexity, you end up returning factor simpleComplexity which ends up being simpleComplexity^2 / (adjustmentWeight geographicalDistance). Not sure if the squaring is intentional Otherwise I think logic looks good

— Reply to this email directly, view it on GitHubhttps://github.com/Davidrxyang/raines-2024-line-addition-problem/pull/71#issuecomment-2212520015, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDH4W6XI7GRLDHPT4OKDZDZLF43XAVCNFSM6AAAAABKO56URGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGUZDAMBRGU. You are receiving this because you authored the thread.Message ID: @.***>

henrydeng2002 commented 1 week ago

looks good then