search

DavidsonGroup / flexiplex

The Flexible Demultiplexer
https://davidsongroup.github.io/flexiplex/
MIT License
26 stars 2 forks source link

Change endls to \n #13

Closed edoyango closed 1 year ago

edoyango commented 1 year ago

Hi @nadiadavidson

This is the pull request that shuyi would've mentioned yesterday.

It changes the endls in cerr and cout statements to "\n"s. This is generally better practice as endl causes the program to flush writes to the filesystem. Frequent flushing can cause performance degradation. endl is only recommended when the output needs to be seen immediately e.g., after info or debug messages.

I can confirm that the modified program produces identical results for Shuyi's pipeline.

I unfortunately couldn't reproduce the error messages ITS had initially brought up, so I can't 100% confirm that removing the endl's resolves this.

But hopefully this fixes things!

nadiadavidson commented 1 year ago

Tested this pull request on a few validation datasets and found no change to output (content or speed), so happy to merge this.