search

Davidy22 / SkunkBooth

Text based command line webcam photobooth app
https://Davidy22.github.io/SkunkBooth/
Other
50 stars 12 forks source link

#55 keyboard shortcuts #57

Closed josflesan closed 3 years ago

josflesan commented 3 years ago

Fixes #55

I have added the global shortcut bindings to close the application (q, esc, ctrl+w and ctrl+q) as well as the navigational shortcuts for the filter screen (pgUp, pgDown, Home, End).

However, I am not sure how the ctrl+arrow keys shortcut should behave from the issue description. Should they behave similarly to the home and end keys in the filter screen? If you could please clarify this point, I'd be happy to go in and implement that final shortcut too. I hope everything else is right and up to standard :)

Davidy22 commented 3 years ago

Yeah, regular CTRL+arrow key behavior, jump all the way to the end. I also wanted to see it on the main menu screen, so we'd be jumping left and right too. Github default for the auto lint for new contributors seems to have been on an approval basis, I've gone in and changed the setting so first time commits don't have to wait anymore, but now that it has it seems like there's a few lines that the lint wants a little bit more elaboration on. You can run pre-commit install In the project top level directory and it'll add some checks to your git setup so that it automatically alerts you before you commit if the lint would raise an issue.

Davidy22 commented 3 years ago

Gave it a spin and it works well enough, merging.