Davidy22 / SkunkBooth

Text based command line webcam photobooth app
https://Davidy22.github.io/SkunkBooth/
Other
50 stars 12 forks source link

Add description column to filters, and censored version of the ad filter #58

Closed Davidy22 closed 3 years ago

Davidy22 commented 3 years ago

Also ran black on frames.py, this also probably should get split up as the program gets bigger.

Trisanu-007 commented 3 years ago

skunkbooth-fault Could use some padding on the right side Ig. Also what's the thing with the ad filter? Rest all looks good.

Davidy22 commented 3 years ago

The filter from the video that I didn't commit, now censored

Trisanu-007 commented 3 years ago

The padding is there, but the slight thickening of the border is also there.

Davidy22 commented 3 years ago

Put a little row of . down the side for visual seperation, is there more than that you're seeing on the border?

Trisanu-007 commented 3 years ago

The same right border in the picture above, but with a bit of padding this time.

Davidy22 commented 3 years ago

Is padding not what we wanted?

Trisanu-007 commented 3 years ago

padding seems fine, the right border looks different than the left one. The right is like the pic above and left is thin as usual.

dhananjaylatkar commented 3 years ago

skunkbooth-fault Could use some padding on the right side Ig. Also what's the thing with the ad filter? Rest all looks good.

@Trisanu-007 why is Box aligned to left? Shouldn't it be centered?

dhananjaylatkar commented 3 years ago

Can we think of something witty instead of "Everything is _" for description?

Trisanu-007 commented 3 years ago

Hmm yeah the alignments changed too, can you test on your machine too?

dhananjaylatkar commented 3 years ago
Screenshot 2021-08-05 at 7 17 21 PM

Using pipe symbol with one space.

@Trisanu-007 i'm not seeing alignment problems

Trisanu-007 commented 3 years ago

The right side is still messed up tho

Davidy22 commented 3 years ago

What's the issue on the right side?

Trisanu-007 commented 3 years ago

The right border doesn't look messed up?

Davidy22 commented 3 years ago

It looks like a scrollbar. I guess the handle is a bit too small for a screen with nothing to scroll, but I think that's unconfigurable asciimatics stuff

Trisanu-007 commented 3 years ago

In that case, this works. Ill merge it if that's okay?

Davidy22 commented 3 years ago

Yeah sure