search

Davidy22 / SkunkBooth

Text based command line webcam photobooth app
https://Davidy22.github.io/SkunkBooth/
Other
50 stars 12 forks source link

Clean up main.py #61

Open Davidy22 opened 3 years ago

Davidy22 commented 3 years ago

main.py has become a bit of a dumping ground, clean it up a little bit by moving what should be moved out into other files.

Arnab1181412 commented 3 years ago

Hey I want to fix this issue im new to github contributor and have good knowledge of python and can you give some context to it

rashidkalwar commented 3 years ago

yeah I can see, it is a bit mess in there, I can help solving it, assign it to me, I will make a PR as soon as I can.

Davidy22 commented 3 years ago

Oh whoops, github scrolled me to the bottom so I only saw rashid before I assigned. Well, there's another similar ticket so I can assign that one to arnab

rashidkalwar commented 3 years ago

hey @Davidy22 I made some changes and then made a pull request but I saw in the post commit their were some spacing and indentation issues, I checked and fixed all, still facing errors, please have a look where am I messing wrong.

rashidkalwar commented 3 years ago

sorry for all that mess with commits

Davidy22 commented 3 years ago

You can run pre-commit install on the top level directory to install hooks that'll check your code on your machine and tell you what lines need checking.

rashidkalwar commented 3 years ago

@Davidy22 just closed the last PR, and made a new one this time looks great, please have a look and let me know.

rashidkalwar commented 3 years ago

@Davidy22 I am having a hard time understanding it and honestly I don't know what can mess wrong, since you have the access to make changes to my Pull Request, please modifying it so it doesn't crash anything.

Davidy22 commented 3 years ago

I can take a look later after I get some stuff I wanted to clear done, but this should just be a matter of passing a reference to the buffer into the function.

Davidy22 commented 3 years ago

Still busy with my stuff but it seems like rashid's having trouble with this, I'll assign both of you to this since I think github hasn't pinged arnab for the other ticket I mentioned him in, you can try fix up rashid's attempt or start from scratch.

Davidy22 commented 2 years ago

Unassigning the two of you since it doesn't seem like this is going to get done.

bhanu0002 commented 2 years ago

main.py has become a bit of a dumping ground, clean it up a little bit by moving what should be moved out into other files.

Hey. since no one is doing anything about it, I want a chance to do some clearing. It will be my first commit after quite a while.

Thank you.

Davidy22 commented 2 years ago

Sure, make the PR and I'll check it to make sure it works.