Davidy22 / SkunkBooth

Text based command line webcam photobooth app
https://Davidy22.github.io/SkunkBooth/
Other
50 stars 12 forks source link

cleaned up main.py and refactored code. #68

Closed rashidkalwar closed 3 years ago

rashidkalwar commented 3 years ago

Hi @Davidy22

I did some major changes, specially with the nested functions inside main.py, I created a file inside utils to manage all those changes and distribute the code. now main.py looks a little bit clean, please check all changes thoroughly and let me know if I should make any changes.

also I am new to the open source and software engineering in general, so please let me know your thoughts how am I doing.

thanks!

Davidy22 commented 3 years ago

Looks like there's some lint checks failing. Run pre-commit install in the top level directory and it'll run the linter on your code when you try to commit. I feel like main could get cleaned out a little more too, good start though

dhananjaylatkar commented 3 years ago

You should use black to format the code. It'll get rid of linting errors. Also enable pre-commit as suggested by David.