search

Davidy22 / SkunkBooth

Text based command line webcam photobooth app
https://Davidy22.github.io/SkunkBooth/
Other
50 stars 12 forks source link

[FEATURE] Make a onscreen timer of some sort for the recording part #73

Closed Trisanu-007 closed 2 years ago

Trisanu-007 commented 3 years ago

Is your feature request related to a problem? Please describe. Once the recording button is clicked, start an onscreen timer with "REC"

Describe the solution you'd like Simple state based implementation should do it.

Describe alternatives you've considered None.

Additional context None.

s-surineni commented 2 years ago

Hi, Can I work on this feature?

Trisanu-007 commented 2 years ago

Yeah sure, make sure to follow the guidelines and if you have any problems, don't hesitate to ask.

s-surineni commented 2 years ago

@Trisanu-007 I thought of changing the record checkbox to a timer. But asciimatics doesn't have a timer widget. Can you please suggest a way ahead? Should I use a label widget to controls_layout and update it according to the video duration?

Davidy22 commented 2 years ago

Asciimatics has this example with auto updating text that might be helpful for reference

Trisanu-007 commented 2 years ago

@s-surineni check out David's reference and see if it would be a good fit. Also updating a custom widget does seem a good way too, but I cant speak for the performance. Do give it a try though.

Trisanu-007 commented 2 years ago

@s-surineni how's it going ?

s-surineni commented 2 years ago

@Trisanu-007 This week is busy workwise. I'll on this over weekend

s-surineni commented 2 years ago

@Trisanu-007 I've raised a PR to the issue. Please review and let me know if any changes are required. I did manual testing for the new code