search

Davidy22 / SkunkBooth

Text based command line webcam photobooth app
https://Davidy22.github.io/SkunkBooth/
Other
51 stars 12 forks source link

feat : added utility to read camera live image stream #9

Closed garuna-m6 closed 3 years ago

garuna-m6 commented 3 years ago

@Davidy22 can you help me in the checks ?

dhananjaylatkar commented 3 years ago

@Davidy22 can you help me in the checks ?

Use flake8 to see/fix errors.

dhananjaylatkar commented 3 years ago

@garuna-m6 which function returns cv2 or PIL image? I need one of those so that I can feed it into show_image function.

Trisanu-007 commented 3 years ago

@garuna-m6 took care of the checks, enjoy !

Davidy22 commented 3 years ago

It looks like this does conversion to ASCII straight from openCV which is nice, we need the result as a return value instead of just printed to screen though so that this can be integrated into the rest of the program. Also fold this into a class with cap as an attribute of the class so that it's a little more cleanly accessible.

Also separate the opencv image capture and the conversion to ASCII into two separate functions because @dhananjaylatkar was assigned conversion to ASCII and I believe they have a different-looking converter for the camera output in the frame variable and they'd like to be able to access it

Davidy22 commented 3 years ago

Yeah this does what we need it to, can probably come back for cleanup and optimisation but I'll merge for now.