Addressed issue #53 and added new filters for #69

Davidy22 / SkunkBooth

Text based command line webcam photobooth app

https://Davidy22.github.io/SkunkBooth/

Other

50 stars 12 forks source link

Addressed issue #53 and added new filters for #69 #95

Closed johnperry99 closed 2 years ago

johnperry99 commented 2 years ago

We've added the following filters for issue #69:

Greek Letters
Musical Notes
Suits from a deck of cards
Warm color filter
Cold color filter
Night vision
Posterize (cool effect that reduces bits in color channels)
Dark auto contrast (for improving camera quality in a dark room)
Math symbols
Enhancement filters for both color and grayscale images

We also addressed #53 by creating a pretty screen for when saving at the end.

johnperry99 commented 2 years ago

Hi @Davidy22 this is ready for your review whenever you're available

Davidy22 commented 2 years ago

For now to merge this you can drop the commits related to #53 and create a seperate PR to resolve and finish closing screen.

Davidy22 commented 2 years ago

Just checking in again, if you need this merged for your class you can drop the extraneous commits and I can merge the reformed PR, but I won't merge this with the end screen as-is because it introduces very undesired behavior if remaining workload lasts longer than the fixed length end screen

Davidy22 commented 2 years ago

I'm going to close this so that a new PR with just the filters can be created. If you manage to produce a working version of the closing screen, I can look at that in a separate pr.