search

DavinciDelta / pe

0 stars 0 forks source link

updatelog does not update log properly #8

Open DavinciDelta opened 8 months ago

DavinciDelta commented 8 months ago

following the example, the program is unable to find the exercise to update

steps to reproduce:

log 1 26 Basketball 179

updatelog 1 26 Basketball 179 Rugby 55

Expected:

update of basketball into rugby and 179 to 55

Actual: Error in finding exercise

image.png

image.png

nus-pe-script commented 8 months ago

Team's Response

As mentioned in the other issue, the inputs that the user is inputting into the program are incorrect and thus causing an error. A correct example has been provided in the other issue as well as a picture showing how it should function. However, it is evident that the UG was not clear enough to the user to show them how the updatelog command should be used properly.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

updatelog command does not seem to work

Details: updatelog command does not seem to work as my exercises always cannot be found despite the input being seemingly correct.

Steps to replicate:

  1. log an exercise log 11 11 Running 100
  2. attempt to update log updatelog 11 11 Running 100 Jogging 200

image.png

image.png

image.png

[original: nus-cs2113-AY2324S1/pe-interim#815] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Screenshot 2023-11-19 at 00.38.58.png

This issue has been considered rejected because the program user did not input and use the update log command properly. Yes, the first part of the command updatelog 11 11 Running 100 is correct, but as you can see from the Example of usage section, between stating the exercise that you want to update and the new details that you want to update that exercise with, there is a space indicating that they should be two separate inputs. Therefore, the correct sequence of inputs into the program should have been log 11 11 Running 100, then updatelog 11 11 Running 100, and finally Jogging 200. However, it is evident that the UG was not clear enough to the user to show them how the updatelog command should be used properly.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Not only was the UG "not clear" but it was also different from your example. As we test based on the Developer Guide and the User Guide PDF files. To a normal user it was suggested to type "updatelog 1 26 Basketball 179 Rugby 55" based on the User guide. I believe this could be of a lower severity since it can be a documentation error on your part.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.High`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]