DavisVaughan / furrr

Apply Mapping Functions in Parallel using Futures
https://furrr.futureverse.org/
Other
699 stars 40 forks source link

Process revdeps #157

Closed DavisVaughan closed 4 years ago

DavisVaughan commented 4 years ago

abjutils

Nothing to fix

https://github.com/abjur/abjutils/issues/15

'::' or ':::' import not declared from: ‘lifecycle’

This package Suggests furrr, but then does two things incorrectly:

baguette

https://github.com/HenrikBengtsson/globals/issues/59

disk.frame

Nothing to fix

It looks like disk.frame:::setup_disk.frame() failed to start its workers. I would guess that this is separate from furrr, since that function doesn't use anything from furrr. Might just be a random fluke.

Update: This one went away on a second round of revdeps, so I'll call it a fluke

photosynthesis

Nothing to fix

Issue with dev magrittr and piping into a return() call. Lionel says it is an intended change.

library(magrittr)

x <- 1:5

foobar <- function(x) {
  x %>% return()
}

foobar(x)

simhelpers

Nothing to fix

Running this example with and without parallel doesn't break when I do it locally, so not sure what is happening here

library(simhelpers)
library(furrr)

df <- data.frame(
  n = 3:5,
  lambda = seq(8, 16, 4)
)

#plan(multisession, workers = 2)

evaluate_by_row(df, rpois)

The error that occurs on revdepcheck is:

Error in ...furrr_fn(...) : could not find function "...furrr_fn"

It persists through a second round of revdeps so it is worth looking at again

Update: I can reproduce this with CRAN globals. It is the problem where rpois gets remapped to ...furrr_fn and isn't found. It works with dev globals. I am not sure why revdepcheck didn't use the dev version, since it is in Remotes