Davoleo / Metallurgy-4-Reforged

The unofficial port to 1.12.2 of Metallurgy 4
https://minecraft.curseforge.com/projects/metallurgy-4-reforged
GNU General Public License v3.0
34 stars 24 forks source link

Use Tinker's event instead of overriding existing materials #158

Closed LemADEC closed 5 years ago

LemADEC commented 5 years ago

Describe the bug Game crash on load when stats are already defined in Tinker's Construct, advising to use events insteads.

To Reproduce Start the game

Expected behavior Games boot

Versions:

Crash Report https://gist.github.com/LemADEC/7e371f8d66bae637c925b197304380f9

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Metallurgy 4: Reforged (metallurgy)
Caused by: slimeknights.tconstruct.library.TinkerAPIException: [TCon API] Could not add Stats to "adamantine": Stats of type "core" were already registered by MMDLib. Use the events to modify stats.
    at slimeknights.tconstruct.library.TinkerRegistry.error(TinkerRegistry.java:951)
    at slimeknights.tconstruct.library.TinkerRegistry.addMaterialStats(TinkerRegistry.java:232)
    at slimeknights.tconstruct.library.TinkerRegistry.addMaterialStats(TinkerRegistry.java:208)
    at it.hurts.metallurgy_reforged.integration.mods.IntegrationCArmory.preInit(IntegrationCArmory.java:36)
    at it.hurts.metallurgy_reforged.Metallurgy.preInit(Metallurgy.java:91)
HurtsAsHell commented 5 years ago

The problem is the conarm and it will fix in the next release