Davoleo / Metallurgy-4-Reforged

The unofficial port to 1.12.2 of Metallurgy 4
https://minecraft.curseforge.com/projects/metallurgy-4-reforged
GNU General Public License v3.0
35 stars 24 forks source link

Spartan's Weaponry integration oversight #381

Closed Beeflauncher closed 5 months ago

Beeflauncher commented 5 months ago

General Information

While testing update 1.4.0, I noticed a slight oversight with weapons that are based off of materials with unique swinging speeds(eg: platinum, quicksilver, ignatius, etc). Their attack speeds seem to be the same as weapons without unique attack speeds.

That's really all.

Davoleo commented 5 months ago

This is because SpartanWeaponry's own ToolMaterial system doesn't support attack speed unlike ours, so stats like that are not integrated directly. SpartanWeaponry API to create items doesn't seem to support changing their attributes so the possible solutions to this would be:

Adding even more to this developing integration for SpartanWeaponry can take a lot of time, since SpartanWeaponry on the latest version uses Mixins to implement certain features, which renders the mod incompatible with my dev environment since I'm currently using really old toolchain (ForgeGradle 2.3), this means I need to test on an older version of the mod and to test things on the latest I need to first compile the mod and test externally increasing dev times greatly. Both solutions are not really enticing due to the reasons mentioned above, so, at least for the moment and until I may upgrade the project toolchain this won't be implemented.