Teacher absence merge edge case

[Davr1]

For some reason the web bakalari ui displays the lesson as changed while it should just be absent, which also creates inconsistencies with our data model

{
  "type": "atom", // should be "removed"
  "subjecttext": "Německý jazyk | Mon 6/11 | 3 (10:00 - 10:45)",
  "teacher": null,
  "room": "104",
  "group": "P3.B 3.sk",
  "theme": "Zwischenstopp", // should be empty
  "notice": "",
  "changeinfo": "Merged: P3.B(3.sk), Kleinová Radka (P3.B(3.sk), Bečvářová Hana)",
  "homeworks": null,
  "absencetext": null,
  "hasAbsent": true,
  "absentInfoText": "Absc | Obecná absence učitele"
}

[iCyuba]

ugh this is annoying, what about the other lessons tho? why don't they have "Absc" as the abbreviation as well?

[Davr1]

the empty ones are "removed"

{
  "type": "removed",
  "subjecttext": "Mon 6/11 | 4 (10:55 - 11:40)",
  "absentinfo": "Absc",
  "InfoAbsentName": null,
  "removedinfo": "Merge of lessons: TGR, Strnka Richard (P2.B(3.sk), NEJ)"
}

and the one Absc lesson is actually "absent" (bečv doesn't normally have a lesson at that time)

{
  "type": "absent",
  "subjecttext": "Mon 6/11 | 6 (12:45 - 13:30)",
  "absentinfo": "Absc",
  "InfoAbsentName": "Obecná absence učitele",
  "removedinfo": ""
}

[iCyuba]

that's stupid, how do you wanna handle this? render them all as absent?

[Davr1]

maybe 😭 like I assume vodicka just marks a range of lessons as absent all at once the same way he can do for students

[Davr1]

we should definitely add the absc text to all of them to make it consistent or make them all empty

[iCyuba]

I mean idk how bakalari handles it internally, either way tho, I think we should render the "Absc" text as you said.

Do you wanna do this on the current parser or nah? I'll for sure add it to the new one, but not sure if it's worth it to redo the old classes

[Davr1]

I refrain touching the current parser

[iCyuba]

it's your creation tho😭

[Davr1]

keeping it there for historical purposes

[iCyuba]

and for the pluses, let's be fr💀

[Davr1]

[iCyuba]

This has already been fixed in the api, we just need to update the web app so it actually uses the api😭