search

DavyJonesLocker / client_side_validations

Client Side Validations made easy for Ruby on Rails
MIT License
2.69k stars 403 forks source link

DRY Inclusion and Exclusion active model modules #593

Closed tagliala closed 7 years ago

tagliala commented 9 years ago

https://codeclimate.com/github/bcardarella/client_side_validations/issues/categories/duplication

Tests pass but Is it ok to write:

module ClientSideValidations::ActiveModel
  module Inclusion

    include Exclusion

  end
end

?

bcardarella commented 9 years ago

You could extract out to a more common mixin to mix into both