search

DavyJonesLocker / postgres_ext-serializers

MIT License
324 stars 30 forks source link

Fix error where visitor requires 2nd argument in Arel v6 #29

Closed BenMorganIO closed 8 years ago

BenMorganIO commented 9 years ago

After testing @crossroads changes, I think its worthy of getting this into the project. LMKWYT

AlexEmerson commented 9 years ago

Is there any chance to have the request merged? Have this problem with wrong number of arguments for visitor.

danmcclain commented 9 years ago

@AlexEmerson if you look at #30, which shares a lot of code with this, I have concerns about potentially improper string escaping, which could allow sql injection

AlexEmerson commented 9 years ago

Thanks for the reply. It makes sense, keep up your great job. Unfortunately, can't help you guys here. Since I don't need to insert users' data into sql query gonna use @crossroads's version for a while.

felixbuenemann commented 8 years ago

The code from the crossroads fork has been merged in PR #38.