search

DavyLandman / p1-esp8266

P1 serial forwarder for use in HomeAssistent
18 stars 5 forks source link

Added Secrets for WiFi credentials. #1

Closed spoetnik closed 2 years ago

spoetnik commented 2 years ago

Added Secrets file for WiFi credentials.

DavyLandman commented 2 years ago

Thanks, I wanted to avoid anyone committing that file, so that is why I explicitly added it to the .gitignore.

What do you think about making this into to a secret_template.h file? And extend the README.md?

spoetnik commented 2 years ago

aaah, I didn't notice the .gitignore. Either way, the defaults didn't build, and the readme wasn't clear so i thought i fixed it this way. You solution with a template-file and clear directions in the readme would be even better I think.

Thanks for this repo by the way.

DavyLandman commented 2 years ago

Did it work for you?

spoetnik commented 2 years ago

Did it work for you?

Yes! Uninstalled Mosquitto, as it was only needed for receiving messages from the P1 meter.

DavyLandman commented 2 years ago

Thanks, happy to hear I've helped more than just myself.

Also thanks for updating the PR, merged it 👌🏼