Daw588 / vanita

Save, and wear Roblox outfits with nice-to-have features like importing, exporting, and tagging.
GNU Affero General Public License v3.0
12 stars 4 forks source link

I'm having issues with avatars that have layered clothing #3

Closed vernilla closed 9 months ago

vernilla commented 12 months ago

Hi! Thrilled to find this extension!

I started saving my old avatars into it, but I'm having some trouble with ones that have layered clothing. I use BTRoblox's layer restriction removal flag, but not all the avatars affected make use of this, I don't think. I don't have enough avatars to test with or time to sit down and do it at the moment, unfortunately.

Still, any info you need...logs, console, outfit specifics, I'd be happy to provide!

Expected behavior: I click an avatar, the page reloads, I have the avatar equipped (rad). Actual behavior: I click an avatar with no layers, it works as expected. I click an avatar with layers, nothing happens and the page stops reacting properly. I'm not sure when this happens, but at some point during me clicking and refreshing, the names of them sometimes change to TEMPORARY.

image

The two seen here named TEMPORARY, as well as the 'beta sally' on the list are all layered, and all originally had names -- sally 2023 and baron 2023 are the renamed ones.

Daw588 commented 12 months ago

Thank you for your report, I am aware of the issue, although I did not act on it, as I didn't know whether it was worth fixing given the low amount of users utilizing this extension, if any. I suspect the issue is related to the fact that I am presumably using an older version of the Roblox API, which does not support layered clothing. Since you rely on this feature, I will try to fix it as soon as I can, though it can take up to a month until I get started; it solely depends on whether I find some free time to work on this. Additionally, if you will be using the extension through the Chrome store, it may take a good while before it gets updated as the extension needs pass manual review process, just keep that in mind. I will keep you updated, and hopefully I can get this done by end of this week.

vernilla commented 12 months ago

Thank you!! I'm excited for it! I have some folks excited for it too now! I had no idea this extension existed but I'm def gonna be sharing it with folks <3

Daw588 commented 11 months ago

I couldn't build the extension anymore, thus I decided to rewrite it from scratch, and I am confident that it will be significantly better. Here is a roadmap:

I will update you once I get these sorted out.

vernilla commented 11 months ago

Eee, I'm excited! Thank you for taking this on!!

Daw588 commented 11 months ago

I'm almost done, though there is a bit of things that I need to polish out, before I can release it. I don't want to keep you in the dark, so here is some screenshots:

Home
![U6Bu9cY89m](https://github.com/Daw588/vanita/assets/44325281/429c9a66-3fed-4110-b2ba-634a3142cb85)
Home (options expanded)
![aIqWjDkagK](https://github.com/Daw588/vanita/assets/44325281/e4dc48ae-a143-4cb0-b27e-9d076a7bf5c7)
Outfit Editor
![eMQxXx6sRW](https://github.com/Daw588/vanita/assets/44325281/b1fb1e31-119e-4c84-bf88-64f2c92f1880)
Outfit Editor (options expanded)
![AJlQFYQsnI](https://github.com/Daw588/vanita/assets/44325281/a3bf9853-2629-408b-9d72-c214a8a4bfa9)
vernilla commented 10 months ago

Oh man, I didn't see this until now, I'm so sorry!! This looks awesome!

Daw588 commented 10 months ago

It's fine. I was unable to work on this extension for a while now, might be able to finish it by this weekend, though no promises. I also wanted to see if there would be issues with thumbnails due to a concern that Roblox changed their system, which deletes thumbnails after certain amount of time (presumably 30 days), and I have confirmed it recently as some of my avatar thumbnails have gone missing, therefore expired, and are no longer accessible through the generated link. I will have to change the system a bit to save the thumbnail image data on local computer, along with the other metadata associated with saved avatars through this extension.

Daw588 commented 9 months ago

Happy New Year everyone 🎆

I have good news to share. I stayed up the whole night to ensure that the update is complete on the first day of 2024. It is officially done as the update has been submitted for a review to Google Web Store. I know this update took a long time to be completed, but that's what it is when I have other responsibilities to fulfill. I will let you know when the review is complete, and hopefully it will pass so that there will be no further delays. Once you try it out, please let me know if the issue you originally mentioned has been resolved. Here is a video showcasing the update: https://www.youtube.com/watch?v=98DkSFJKtAs.

Daw588 commented 9 months ago

Unfortunately when I was uploading the extension I removed a host permission, because I thought that "activeTab" permission would grant the host permission as stated per documentation but the wording was confusing. Today when I tried to use my extension to verify that it still works, it turned out to be broken, because of this quick change. The version pending in review is broken, and sadly there is nothing I can do to cancel the review. I will have to wait few days up to weeks to have it go through the review, and then upload the new version, and submit again for a review. This means that there will be a quite bit of delay, sorry 😞

However, you can try out the extension early by downloading it from the latest release on GitHub, and once the extension passes the review on Google Web Store, you can just export your outfits, and then import them to the Google Web Store version.

Daw588 commented 9 months ago

I have looked further into permissions, and it turns out that I don't need cookies permission nor host permission, which should significantly reduce review times. Additionally, the 3.0.1 update is out on Google Web Store, though I plan to submit 3.0.2 to remove 2 risky permissions.

Daw588 commented 9 months ago

On my end the issue is resolved, and there doesn't seem to be any responses regarding this issue, so I will consider this as completed. If you encounter any issues, or would like to request a feature, or a change, feel free to open a new issue.