Extension is completely broken! Error message: payload.data is not iterable when importing or exporting - Githubissues

DawnbrandBots / deck-transfer-for-master-duel

A browser extension to import and export Yu-Gi-Oh! decks from Master Duel and Neuron, and download public decks from the official card database.

https://ygoprodeck.com/decks/transfer-tool/

GNU General Public License v3.0

9 stars 0 forks source link

Extension is completely broken! Error message: payload.data is not iterable when importing or exporting #15

Closed jmoransi closed 4 months ago

jmoransi commented 4 months ago

Actual behaviour

When importing deck from Dueling book either using YDKE code or YDK file, an error message appears with the following message

payload.data is not iterable

Expected behaviour

Import YDK file
Deck should appear in official yugioh db

Browser, and version if you know

Microsoft Edge Version 126.0.2592.56 (Official build) (64-bit)

Operating system and version

Windows 11

jmoransi commented 4 months ago

Same YDK file can be imported into YGOProdeck website

attaching YDK file LabJack3.zip

kevinlul commented 4 months ago

Thanks for reporting a bug! I have reproduced this issue and continue to investigate.

kevinlul commented 4 months ago

This problem is caused by a change in behaviour in the YGOPRODECK API.

This breaks all functionality of this extension, import and export, and is not specific to the provided deck.

kevinlul commented 4 months ago

I have reported this issue to the site owner, pending a response tomorrow. In the event that this change is behaviour is intended and permanent, I have also prepared a fix in the extension.

kevinlul commented 4 months ago

This should be resolved now.

kevinlul commented 4 months ago

Fix reconfirmed. Thanks again for reporting this. I'm currently working on automated tests in #10 that would catch this kind of error sooner.