search

Dawoodoz / DFPSR

Fast realtime softare rendering library for C++14 using SSE/AVX/NEON. 2D, 3D and isometric rendering with minimal system dependencies.
https://dawoodoz.com/dfpsr.html
78 stars 6 forks source link

Handle shift and control of uncertain left/right #87

Closed Dawoodoz closed 1 year ago

Dawoodoz commented 1 year ago

Tried with another keyboard, which did not distinguish between left and right shift and control keys.

A quick fix is to assign unknown to the left side. This may seem wrong, but will retain backwards compatibility and fix the bug in existing applications.

Breaking compatibility by merging keycodes would always be caught by the compiler and an easy fix with automatic text replacement, assuming that nobody needs the left/right distinction.

Introducing a third value like on MS-Windows would make it difficult to test applications.

Dawoodoz commented 1 year ago

Fixed in the experimental branch, but needs more testing to make sure that the solution makes sense before going into master.

Dawoodoz commented 1 year ago

Tested the same keyboard on Linux and there it was forced to select left or right sides, because X11 has no undecided version of the keycodes.