search

Dawoodoz / DFPSR

Fast realtime softare rendering library for C++14 using SSE/AVX/NEON. 2D, 3D and isometric rendering with minimal system dependencies.
https://dawoodoz.com/dfpsr.html
78 stars 6 forks source link

Fix naming of character encodings #88

Closed Dawoodoz closed 1 year ago

Dawoodoz commented 1 year ago

CharacterEncoding was first introduced for saving text files, so the formats that included a byte order mark had BOM_ prefixes.

Later came a separate argument telling if the BOM should be allowed or supressed, making a contradiction with the prefix. Then other methods started using the same enumeration.

It would be a relatively easy fix to automatically remove all the BOM_ prefixes, so that version 1.0 can be more easy for new users to learn.

Dawoodoz commented 1 year ago

Not sure if adding the complexity of automatic refactoring would make it worth simplifying the names, but a refactoring tool is needed either way for multiple purposes.

Dawoodoz commented 1 year ago

Automating word replacement derailed into an overly complex project with no well defined end in sight, so the names can stay as they are to keep it simple and reliable.