Dax89 / WebPirate

A Tabbed, WebKit based Browser Web for SailfishOS
GNU General Public License v3.0
15 stars 7 forks source link

Night mode: be always dark #57

Open Mikaela opened 9 years ago

Mikaela commented 9 years ago

Some pages cause the screen to flash as white (when night mode is enabled which hurts eyes for example:

WebKit bug, I presume?

Dax89 commented 9 years ago

Not really a bug, but a limitation. Night mode works by applying a custom CSS to the entire page, the problem is that it will be applied shortly after the webpage is loaded and displayed that's why you see the flashing effect.

Yes, it can be improved. One thing that I can do is to delay the webpage rendering when night mode is enabled so the flashing effect is not visible to the user, but I don't know if this is possible

Mikaela commented 9 years ago

I see. I also noticed that scrolling too much also brings the brightness.

Dax89 commented 9 years ago

You can try the improved night mode with this dev package! https://dl.dropboxusercontent.com/u/40206233/Progetti/harbour-webpirate-1.5-2.armv7hl.rpm

Mikaela commented 9 years ago

Will I still get updates from store after installing or do I have to notice the updates by myself?

54 still isn't fixed unless the fix just didn't come to that package.

Night mode seems to work better with quick testing now, but if I zoom or go further from the page (two fingers to either direction) the whiteness comes.

Dax89 commented 9 years ago

Mikaela Will I still get updates from store after installing or do I have to notice the updates by myself?

Yes, because is still 1.5-x!

Mikaela

54 still isn't fixed unless the fix just didn't come to that package.

I have fixed it in subsequent commits :)

Mikaela Night mode seems to work better with quick testing now, but if I zoom or go further from the page (two fingers to either direction) the whiteness comes.

That's a component issue, by default, WebView's background is white. It's just a background, probably it can be changed, I have to figure out how! I'll reopen this request, as reminder.

I have released 1.6 in OpenRepos, you can download it from there or wait until it lands in the Harbour :)

Mikaela commented 9 years ago

Yes, because is still 1.5-x!

I see, I haven't followed version numbers so much. Odd for development even for stable? ZNC used that before.

I have released 1.6 in OpenRepos, you can download it from there or wait until it lands in the Harbour :)

I will probably wait, OpenRepos broke for me some time ago and even if I factory reset after that it's probably the best I don't use it unless I absolutely have to (Call Recorder).

Dax89 commented 9 years ago

I see, I haven't followed version numbers so much. Odd for development even for stable? ZNC used that before.

I'm using 1.x for the QtWebKit based browser and 2.x for the QtWebEngine one (hopefully) Just increasing the minor version number, nothing about odd=dev, even=stable.

I will probably wait, OpenRepos broke for me some time ago and even if I factory reset after that it's probably the best I don't use it unless I absolutely have to (Call Recorder).

Ok!

Mikaela commented 9 years ago

Some pages also still start by loading themselves as white, I don't remember which exactly, but at least Dropbox FAQ (I was checking which ports it wants from firewall). This version is a lot better though.

Mikaela commented 9 years ago

mobiili.fi had large white area when started from Communi Sailfish (IRC), but it disappeared by itself after some time.