search

Dax89 / WebPirate

A Tabbed, WebKit based Browser Web for SailfishOS
GNU General Public License v3.0
15 stars 7 forks source link

Bug in tel link #65

Closed eson57 closed 8 years ago

eson57 commented 8 years ago

Tapping a tel link starts the phone app, but it also opens a web search. Default search engine is Startpage.com. screenshot-15-10-14-13-25-45

Dax89 commented 8 years ago

I can't reproduce: it happens here too? http://davidwalsh.name/demo/phone-link-protocol.php

eson57 commented 8 years ago

Nope, and I think I can see why. My link looks like this... tel:+46123456789. Yours don't have the +.

https://developers.google.com/web/fundamentals/device-access/click-to-call/click-to-call#use-the-international-dialing-format

Dax89 commented 8 years ago

I have tried even with the "+" prefix, it doesn't trigger the search.

It should be some kind of unhandled case of tel protocol, probably even mailto and sms are affected by issue

eson57 commented 8 years ago

mailto protocol seems fine, only tel triggers search. Can you try this tel link...? https://ootdfashion.com/contact.php

Dax89 commented 8 years ago

Ok now I can reproduce! :)

The issue is in the "target="_self" attribute, the webpage is reloaded automatically by WebKit:

<a href="tel:+123456789" target="_self">+123456789</a>

It will be fixed in 1.8

eson57 commented 8 years ago

Thanks! :)