search

Dax89 / WebPirate

A Tabbed, WebKit based Browser Web for SailfishOS
GNU General Public License v3.0
15 stars 7 forks source link

Mobile Github.com menu button doesn't work #71

Closed Tichy closed 8 years ago

Tichy commented 8 years ago

This could be a webkit issue, since I saw a similar problem with Webcat, but not with the default (geko) browser. In the mobile version of github, it's impossible to tap the (upper right) menu button. screenshot-16-02-15-12-09-40

Dax89 commented 8 years ago

Are you using Sailfish 2.0.1.7? I noticed this annoying issue after the update

Tichy commented 8 years ago

Nope, I'm still at 2.0.0.10 :)

Dax89 commented 8 years ago

Ah, ok :) I see what can I do, I don't have changed anything in the webview

Mikaela commented 8 years ago

Possibly related: https://github.com/Dax89/harbour-webpirate/issues/58

Tichy commented 8 years ago

I just tried to disable the integrated adblock and to restore my original /etc/hosts, so I can exclude those two.

Dax89 commented 8 years ago

WebKit doesn't provide the WeakMap type:

[D] onConsoleLog:45 - https://assets-cdn.github.com/assets/mobile-c99e3b9fab9d48e38ac4c3094080d11cbd6c2a39aa8b17e9bea4cbccf249b6ef.js(1): ReferenceError: Can't find variable: WeakMap
Dax89 commented 8 years ago

Solved with a polyfill: https://github.com/WebReflection/es6-collections

weakmaptest

EDIT: I will close the issue later