Dax89 / WebPirate

A Tabbed, WebKit based Browser Web for SailfishOS
GNU General Public License v3.0
15 stars 7 forks source link

[SFOS 2.1.0] Closing a tab crashes Webpirate #89

Open Olf0 opened 7 years ago

Olf0 commented 7 years ago

After updating from SFOS 2.0.5.6 to 2.1.0.11, Webpirate 2.1-3 (installed from Jolla Store) crashes almost always when closing a tab (in Webpirate's tab overview, by hitting the X button in the upper right corner of a listed web page there). Tested on two Jolla 1 phones. Note, that Webcat does not exhibit this issue, so it does not seem to be related to Webkit. Unfortunately, this makes my favourite browser under SFOS barely usable. Kudos for creating the best web browser for SFOS.

Olf0 commented 6 years ago

Not: Fixed with the Webpirate release 2.1-4 (recompiled with a recent SailfishOS SDK).

Side note: Works really nicely with QtWebKit 5.212.0 compiled by llelectronics.

Olf0 commented 6 years ago

Sorry for closing this issue prematurely: Webpirate 2.1-4 still almost always crashes, when closing tabs in tabview.

Dax89 commented 6 years ago

I can't reproduce, do you have any log? I'm curious, maybe it can be fixed easily :)

Olf0 commented 6 years ago

Sure.
I did:

  1. Opened Webpirate 2.1-4, created 4 tabs (all tech news sites) and loaded a sub-page on each of them (i.e. clicked on a news item).
  2. Close Webpirate.
  3. [nemo@sailfish ~]$ harbour-webpirate > webpirate-segfault.txt 2>&1 Segmentation fault [nemo@sailfish ~]$
    • What happened: Webpirate opens with 5 tabs (a new Quick Grid tab is opened as first tab).
    • Closed one of the other tabs: Webpirate segfaults.

The content of webpirate-segfault.txt shows nothing special, IMO.

Note, that I upgraded QtWebKit to v5.212.0 compiled by llelectronics last month, but that did not change these crashes (segfaults) at all.

If it is helpful for you, I am willing to downgrade QtWebKit to Jolla's original version, but I would rather like to take more comprehensive crashlogs (as the QtWebKit version used does not appear to make a difference), if you tell me how to do that rsp. what kind of logs you consider to be more helpful / comprehensive for you.