search

Daxbot / node-canopen

CANopen implementation for NodeJS
MIT License
32 stars 11 forks source link

SDO expedited uint32 download produces "general error" #15

Closed johras closed 4 years ago

johras commented 4 years ago

First bit (s) is not set in 4 byte expedited download and therefore a client replies with an error. |0x02 should be |0x03 in init_download function?

wilkinsw commented 4 years ago

Thanks for the report, I'll take a look. What version are you using?

johras commented 4 years ago

I'm using version 1.4.4

The issue is in SDO.js on line 332. Lines 336 and 337 are probably unnecessary after change?

wilkinsw commented 4 years ago

Should be fixed now in version 1.4.7: https://www.npmjs.com/package/canopen/v/1.4.7