DaymareOn / hdtSMP64

hdt-smp for 64 bit Skyrim
MIT License
32 stars 18 forks source link

Entry Point perk effect "Mod Max Placeable Mines" is broken when using FSMP #68

Open phlosber opened 1 year ago

phlosber commented 1 year ago

Describe the bug Some mods like Adamant or Ordinator use a perk Entry Point "Mod Max Placeable Mines" to change how many Destruction Runes one can have active at the same time. In Adamant, the perk name is Rune Mage under the Destruction Tree.

When using FSMP - I tested with Vanilla Hair Remake SMP and also with KS Hairdo SMP - the "Mod Max Placeable Mines" entry point doesn't work. FSMP somehow is causing the perk entry point to be skipped in code.

To Reproduce Steps to reproduce the behavior:

  1. Install only SKSE, USSEP, FSMP, Mysticism, Adamant and Vanilla Hair Remake SMP OR KS Hairdo SMP.
  2. Start a new game.
  3. Cheat your way (or play organically) until you can unlock the first level of perk Rune Mage under the Destruction Tree.
  4. Add the Lightning Rune spell book to your inventory (player.additem 000A2702 1) and equip it.
  5. See that you can place as many runes as you want - even though the perk sets it to maximum 2.
  6. Close the game, disable FSMP, start the game, do the same steps and realize that the perk works correctly (only 2 runes can be active at the same time).

Expected behavior With that perk unlocked in the repro steps, you should have maximum 2 runes at the same time. If you check [PERK:00105F32] in xEdit, you'll see that all the perk does is apply a multiplier to "Mod Max Placeable Mines" so 2 can be active at the same time.

Desktop (please complete the following information):

FSMP

Required files *Configs.xml renamed to .txt because github doesn't support xml upload. configs.txt

hdtSMP64.log

Additional context Add any other context about the problem here.

phlosber commented 5 months ago

Someone also posted on Reddit about it: https://www.reddit.com/r/skyrimmods/comments/vbxj3g/requesting_help_from_other_adamant_users/

Someone created a workaround mod for it: https://www.nexusmods.com/skyrimspecialedition/mods/83381

But it would be good if FSMP actually fixed this. It's very weird that it's hooking into a entry point perk, intended or not (I'm assuming the latter).

snottyone commented 5 months ago

But it would be good if FSMP actually fixed this. It's very weird that it's hooking into a entry point perk, intended or not (I'm assuming the latter).

this is an Adamant bug that has nothing whatsoever to do with FSMP

phlosber commented 5 months ago

But it would be good if FSMP actually fixed this. It's very weird that it's hooking into a entry point perk, intended or not (I'm assuming the latter).

this is an Adamant bug that has nothing whatsoever to do with FSMP

And you're saying this based on...?

It is not an Adamant bug, I tested, both with Adamant, Ordinator and I also created an empty mod that simply uses the aforementioned Entry Point perk.

Test it yourself. Start a new game with nothing but FSMP (and any requirements it might have) + a hair mod; create a new mod in xEdit with a perk that uses the "Mod Max Placeable Mines" entry point; add the perk to your character and see the bug. Disable FSMP, start the game again with your new mod and see the bug is gone.

DaymareOn commented 5 months ago

Hey phlosber, FSMP 1.49? So it isn't related to my introduction of parallelism... I would have thought it was the major suspect.

Second suspect: a hook badly implemented in FSMP. I haven't much time lately, but I could build some test dlls to pinpoint the origin of the bug, and then solve it. Would you help me with the tests? Are you on discord? If so, could you contact me? I'm DaydreamingDay on the discord server which link I have put on the FSMP Nexus description page.