Having FOV accessible to JS

[DaymareOn]

Having FOV accessible to JS

[DaymareOn]

Fields : "rw:max field of view", "rw:min field of view", "rw:rate of change", "rw:initial field of view", "r:angle", "rw:field of view", "rw: requested field of view", "rw:isEnabled". The "requested field of view" would be subject to the "rate of change", and the "field of view" would be instantaneous.

[DaymareOn]

This comment is updated on the go along with the advance of the others.

Properties: Oolite.gameSettings.fov (read-only): game option fov, in degrees PlayerShip.viewFov (read/write): current view fov, in degrees

[DaymareOn]

This must not conflict with 2 other use cases:

• fov set for unusual width like 3 screens,
• fov set via game options.

[DaymareOn]

Fov for unusual width is set via game options, which allows to manage the wider angles. The smaller angles (2° telephoto...) are not used in game options, it would be unusable.

So... the equipment oxp should manage the different use cases arising, only it knows what should be done. What we can do to help is to provide the player chosen game options fov. I add it to the list before.

[DaymareOn]

In fact, the equipment script should check its own min/max angle of view. This should not be checked by the main code. I remove it from the fields.

[DaymareOn]

The equipment specific isFovEnabled() is useless. I remove it from the fields.

[DaymareOn]

Changed fields into methods.

[DaymareOn]

In fact, void: setRequestedAngleOfView(float angleOfView, float rateOfChange) is totally implementable in js with void: setAngleOfView(float angleOfView), so it's useless. I remove it from the methods.

[DaymareOn]

Fov (not game option fov) should be per view. I update the methods.

[DaymareOn]

Must be compatible with OOJSPlayerShip.setCustomView() So... Game option fov is accessible via OOJSOolite, and view fov should be accessible via OOJSPlayerShip. I update the info.

[DaymareOn]

Implemented through ab51fc359691c325577751771c04bcf3001627ef